libxl: In domain death search, start search at first domid we want
authorIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 17 Mar 2015 15:30:57 +0000 (09:30 -0600)
committerIan Campbell <ian.campbell@citrix.com>
Fri, 20 Mar 2015 11:30:35 +0000 (11:30 +0000)
commit4783c99aab866f470bd59368cfbf5ad5f677b0ec
treecfdf4c4718b90540f0908d795cc446d7695ddc87
parenteb84b068f9ffd9684a61d8a7e93f71ff3ff1e53b
libxl: In domain death search, start search at first domid we want

From: Ian Jackson <Ian.Jackson@eu.citrix.com>

When domain_death_xswatch_callback needed a further call to
xc_domain_getinfolist it would restart it with the last domain it
found rather than the first one it wants.

If it only wants one it will also only ask for one domain.  The result
would then be that it gets the previous domain again (ie, the previous
one to the one it wants), which still doesn't reveal the answer to the
question, and it would therefore loop again.

It's completely unclear to me why I thought it was a good idea to
start the xc_domain_getinfolist with the last domain previously found
rather than the first one left un-confirmed.  The code has been that
way since it was introduced.

Instead, start each xc_domain_getinfolist at the next domain whose
status we need to check.

We also need to move the test for !evg into the loop, we now need evg
to compute the arguments to getinfolist.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reported-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Tested-by: Jim Fehlig <jfehlig@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
tools/libxl/libxl.c